🐛 Update PVC permissions #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
requested review from
jortel,
shawn-hurley,
pranavgaikwad and
dymurray
jmontleon
force-pushed
the
update-perms
branch
2 times, most recently
from
7dcbaa3 to
1ea1216
Compare
jmontleon
force-pushed
the
update-perms
branch
from
1ea1216 to
90c6575
Compare
shawn-hurley
approved these changes
Nov 8, 2024
jmontleon
force-pushed
the
update-perms
branch
5 times, most recently
from
656b949 to
82687cb
Compare
|
For whatever reason, when the cache PVC exists the Hub mounts it, so we must scale it down to allow the PVC to terminate so it can be recreated. |
jmontleon
force-pushed
the
update-perms
branch
3 times, most recently
from
934bc87 to
8804bac
Compare
|
Thinking about this more, since the Hub mounts the cache PVC if it exists we probably don't need to delete and recreate it. We should be able to chown everything like the others. It could however take awhile for the process to run, whereas deleting the cache and recreating it may be quicker. Curious what others opinions are with which way we should go. |
|
I think that deleting the cache should be fine and as you said would be quicker |
jortel
reviewed
Nov 13, 2024
jmontleon
force-pushed
the
update-perms
branch
2 times, most recently
from
32f34a6 to
ff063a0
Compare
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
jmontleon
force-pushed
the
update-perms
branch
from
ff063a0 to
d852448
Compare
|
Fixed the hard coded values in the initContainer causeing the e2e-api test failure. |
dymurray
pushed a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com> (cherry picked from commit a09410d)
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.